Skip to content

Restore default logo#8979

Merged
bmuenzenmeyer merged 1 commit into
mainfrom
bmuenzenmeyer-patch-1
Jul 1, 2026
Merged

Restore default logo#8979
bmuenzenmeyer merged 1 commit into
mainfrom
bmuenzenmeyer-patch-1

Conversation

@bmuenzenmeyer

@bmuenzenmeyer bmuenzenmeyer commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Scheduled revert of #8904

Description

Validation

Related Issues

Relates to #6802

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@bmuenzenmeyer
Restore default logo
bddf9c6 
Scheduled revert of #8904

Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner July 1, 2026 14:48
Copilot AI review requested due to automatic review settings July 1, 2026 14:48
@vercel

vercel Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Jul 1, 2026 2:49pm

Request Review

@cursor

cursor Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Single branding config change with no auth, data, or business-logic impact.

Overview
Reverts the temporary pride site logo by removing "logoVariant": "pride" from apps/site/site.json, matching the scheduled undo of PR #8904.

Header branding from WithNodejsLogo will again use the standard default Node.js logo (the Nodejs icon falls back to variant="default" when the config field is absent).

Reviewed by Cursor Bugbot for commit bddf9c6. Bugbot is set up for automated code reviews on this repo. Configure here.

@codecov

codecov Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.44%. Comparing base (18445a2) to head (bddf9c6).
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8979      +/-   ##
==========================================
+ Coverage   75.36%   75.44%   +0.07%     
==========================================
  Files          98       98              
  Lines        8637     8636       -1     
  Branches      319      318       -1     
==========================================
+ Hits         6509     6515       +6     
+ Misses       2124     2117       -7     
  Partials        4        4

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Copilot AI reviewed Jul 1, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the Pride logo configuration change so the site returns to rendering the default Node.js logo variant.

Changes:

  • Removes the logoVariant: "pride" setting from the site configuration JSON.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/site/site.json
@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Jul 1, 2026
Merged
@avivkeller avivkeller added the fast-track Fast Tracking PRs label Jul 1, 2026
@avivkeller

avivkeller commented Jul 1, 2026

Copy link
Copy Markdown
Member

Requesting fast-track

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Jul 1, 2026
Merged via the queue into main with commit 747eb7b Jul 1, 2026
18 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the bmuenzenmeyer-patch-1 branch July 1, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@MattIPv4 MattIPv4 MattIPv4 approved these changes
@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

fast-track Fast Tracking PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bmuenzenmeyer @avivkeller @MattIPv4